feat: ldap & auxiliary interface integration and some improvements

wood-push-melon commented 10 months ago

This pull request includes the following features:

[x] Integration with the ldap interface
[x] Improve the configmap propagation delay issue, and use Pydantic for the ldap interface library
[x] Improve the development process with pre-commit and mypy
[x] Documentations
[x] Integration with the glauth-auxiliary interface

Try to keep the charm.py concise and spread the unrelated logic to other modules. However, it seems to me that there is still room to improve charm.py. More effort will be made in the following pull request.

This pull request will wait for the glauth-utils's PR approved and merged.

shipperizer commented 9 months ago

PR is growing quite big

would we be able to cut it here https://github.com/canonical/glauth-k8s-operator/pull/19/commits/a6cfcea06102f8a479235cfed5b55666010b100d and basically offload all the StartTLS stuff to another pr? @wood-push-melon

wood-push-melon commented 9 months ago

PR is growing quite big

would we be able to cut it here a6cfcea and basically offload all the StartTLS stuff to another pr? @wood-push-melon

Yeah, truncated the certificate-related commit out of this PR, and shift it to another one: https://github.com/canonical/glauth-k8s-operator/pull/20

@nsklikas @natalian98 I will resolve any certificate-related comments in the PR: https://github.com/canonical/glauth-k8s-operator/pull/20

canonical / glauth-k8s-operator

feat: ldap & auxiliary interface integration and some improvements #19