feat: add volume group API endpoint interaction

canonical / gomaasclient

Go MAAS client

Apache License 2.0

23 stars 28 forks source link

feat: add volume group API endpoint interaction #94

Closed summerwind closed 2 weeks ago

summerwind commented 3 months ago

This PR adds the support of following MAAS API endpoint.

DELETE /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/: Delete volume group
GET /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/: Read a volume group
PUT /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/: Update a volume group
POST /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/op-create_logical_volume: Create a logical volume
POST /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/op-delete_logical_volume: Delete a logical volume
GET /MAAS/api/2.0/nodes/{system_id}/volume-groups/: List all volume groups
POST /MAAS/api/2.0/nodes/{system_id}/volume-groups/: Create a volume group

I think this change would resolve #86.

github-actions[bot] commented 3 months ago

Everyone contributing to this PR have now signed the CLA. Thanks!

summerwind commented 3 months ago

I'm trying to fill out to the CLA form, but not sure what to enter the field 'Please add the Canonical Project Manager or contact'.

skatsaounis commented 3 months ago

Hi @summerwind,

Thank you for the contribution. You can put N/A for that box or my name and proceed. Please let me know when this is done or if you face any other issue.

summerwind commented 3 months ago

@skatsaounis Thank you for following up! I have signed the CLA form.

summerwind commented 2 months ago

Is there anything else I should do?

skatsaounis commented 2 months ago

Hi @summerwind. Thank you for signing the CLA. As you observed already, I re-triggered the actions and now everything looks green. Please give us some time to review your PR and if any change is needed we will come back to you. Thank you for your patience :slightly_smiling_face:

summerwind commented 1 month ago

@skatsaounis Thanks for the review! I've fixed the code according to your feedback.

github-actions[bot] commented 4 weeks ago

Everyone contributing to this PR have now signed the CLA. Thanks!

summerwind commented 4 weeks ago

CLA Check seems to have failed due to certificate expiration. https://github.com/canonical/gomaasclient/actions/runs/11621308073/job/32364801159?pr=94

Checking the following users on GitHub: Check in the signed list service Error occurred while checking user: certificate has expired

summerwind commented 2 weeks ago

Thank you for the review!