canonical / grafana-agent-k8s-operator

https://charmhub.io/grafana-agent-k8s
Apache License 2.0
8 stars 18 forks source link

Grafana agent require only one outgoing relation to be Active #205

Closed Abuelodelanada closed 1 year ago

Abuelodelanada commented 1 year ago

Issue

This PR fixes #200

Solution

https://github.com/canonical/grafana-agent-k8s-operator/issues/200#issuecomment-1576949493

We could update the ActiveStatus with a message about which ones are disabled, like: Metrics: off or Metrics & Dashboards: off.

imagen

Context

Before this change you need the following three relations (or grafana-dashboards-provider) to be established to get grafana-agent in ActiveStatus:

Testing Instructions

Run tests ;-)

Abuelodelanada commented 1 year ago

Integration tests still fail. Once fixed, this should be ready to merge.

Now are passing. merging