search

canonical / grafana-agent-k8s-operator

https://charmhub.io/grafana-agent-k8s
Apache License 2.0
8 stars 18 forks source link

overwrite the topology labels when recieving alerts over cos-agent #244

Closed dstathis closed 1 year ago

dstathis commented 1 year ago

Issue

The topology labels are wrong for alerts received over cos-agent. Partially solves #190

Solution

Overwrite the topology labels.

Testing Instructions

  1. Relate zookeeper, grafana-agent, and hardware-observer all to each other.
  2. Relate grafana-agent to cos.
  3. Check that alert rule expression all use zookeeper topology.

Release Notes

Fixed and issue where the alert rules forwarded over cos-agent had the wrong labels.

dstathis commented 1 year ago

Is this something we could easily have a utest/stest for?

Tests coming in another PR before I close the issue.