search

canonical / grafana-agent-k8s-operator

https://charmhub.io/grafana-agent-k8s
Apache License 2.0
8 stars 18 forks source link

Cleanup scenario fixtures #256

Open sed-i opened 1 year ago

sed-i commented 1 year ago

After we split the hybrid repo into k8s and machine (#254), feels like this entire function should probably be removed. Or at the very least rewritten as return charm.GrafanaAgentK8sCharm.

https://github.com/canonical/grafana-agent-k8s-operator/blob/c27f43185bb44de23471768ec553bbfdce7e2f8c/tests/scenario/test_start_statuses.py#L24-L26

https://github.com/canonical/grafana-agent-k8s-operator/blob/c27f43185bb44de23471768ec553bbfdce7e2f8c/tests/scenario/test_start_statuses.py#L57-L59

_Originally posted by @dstathis in https://github.com/canonical/grafana-agent-k8s-operator/pull/254#discussion_r1337276226_