search

canonical / grafana-agent-k8s-operator

https://charmhub.io/grafana-agent-k8s
Apache License 2.0
8 stars 18 forks source link

Fix typo in disk.rules #258

Closed chanchiwai-ray closed 1 year ago

chanchiwai-ray commented 1 year ago

Issue

The metric name node_filesystem_size_bytes_bytes appears to be incorrect due to typo. The correct metric name should be node_filesystem_size_bytes, and it can be verified from the source code of node exporter.

This is a regression from #186

Solution

Fix the typo: node_filesystem_size_bytes_bytes -> node_filesystem_size_bytes

Screenshot from 2023-09-26 12-30-20 Screenshot from 2023-09-26 12-30-32

Context

Prometheus alert rules

Testing Instructions

N/A

Release Notes

Fix typo in the Prometheus alert rules for disk

sed-i commented 1 year ago

Thanks @chanchiwai-ray! Would you be able to do the same in https://github.com/canonical/grafana-agent-operator ?

chanchiwai-ray commented 1 year ago

Sure, I was not aware there's another repo for grafana-agent

sed-i commented 1 year ago

Seems like this is relevant only to the machine-charm. Merging for now. We can cleanup in a followup PR.