search

canonical / grafana-agent-k8s-operator

https://charmhub.io/grafana-agent-k8s
Apache License 2.0
8 stars 18 forks source link

Container push and pull is now supported by harness. Replace mocks #45

Closed Abuelodelanada closed 2 years ago

Abuelodelanada commented 2 years ago

Container push and pull is now supported by harness, see e.g. https://github.com/canonical/grafana-agent-k8s-operator/pull/17/commits/621103cb14fa759dce2ee87bca28e1274241c3ae

_Originally posted by @mmanciop in https://github.com/canonical/grafana-agent-k8s-operator/pull/44#discussion_r845510984_

Abuelodelanada commented 2 years ago

@mmanciop said:

For evidence, these mocks have hidden this bug all along https://github.com/canonical/loki-k8s-operator/pull/138

See https://github.com/canonical/grafana-agent-k8s-operator/pull/44#discussion_r846085904

mmanciop commented 2 years ago

I have already done it in #17