canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.
Apache License 2.0
7 stars 14 forks source link

Remove config validation in update status hook #181

Closed chanchiwai-ray closed 4 months ago

chanchiwai-ray commented 4 months ago

The config validation does not make sense in update status hook because the config options will not change on update status, and the same validation is already done in config changed hook.

chanchiwai-ray commented 4 months ago

Abandon! Now I remember why we are adding config validation in update_status, because if the config is incorrect during config_changed, then the blocked status will be washed away after next update_status if we don't do the config validation again.

dashmage commented 4 months ago

It's a good thing you figured this out, I didn't remember it either. It would be nice if we had a comment explaining this so we don't end up trying to remove it again.