Changing `collect-timeout` will not render hardware exporter's config

canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.

Apache License 2.0

7 stars 14 forks source link

Changing `collect-timeout` will not render hardware exporter's config #200

Closed facundofc closed 4 months ago

facundofc commented 4 months ago

While reviewing #193 I found a defect which I believe causes the hardware exporter's config not to be re-rendered if the newly added collect-timeout charm config is modified. I think collect-timeout needs to be added to the exporter_configs set here.

I have not tested this in any way, it's just derived from a review of an already merged PR so I was unable to comment, please close if this is wrong.

dashmage commented 4 months ago

This is indeed a real issue, thanks for bringing it up. Without this change, the collect-timeout value will not be modified in the exporter's config file when the config changed event runs.