search

canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.
Apache License 2.0
7 stars 14 forks source link

fix: Update collect-timeout during config change event #206

Closed dashmage closed 4 months ago

dashmage commented 4 months ago

Fixes #200

dashmage commented 4 months ago

Thanks to fix the bug and add functional test case. Is it even better to modify the unit test if we want to validate each options? https://github.com/canonical/hardware-observer-operator/blob/master/tests/unit/test_charm.py#L217

The test you linked just checks whether any new config (it uses exporter port and log level) updates the config stored state dict (_stored.config) when added for the first time. I don't think adding collect-timeout specifically would offer any significant value.