search

canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.
Apache License 2.0
7 stars 14 forks source link

Store hw tool list in _stored and reuse it. #214

Closed sudeephb closed 3 months ago

sudeephb commented 3 months ago

The list will be created only once, during the install hook, and the same list will be reused everywhere else. This avoids generating a new list everytime it's needed, and potentially losing a hw from the list when it can't be temporarily accessed. This way, the list of hardware being monitored is predictable. This helps avoid issues like #202 An action to refresh the hardware list will be provided as a future enhancement, so the operators can regenerate the hw tool list if needed.

sudeephb commented 3 months ago

After running the hardware-dependent functional tests, it is observed that some fixes are needed to this. I will push a new commit for that. Marking this as draft until then.

chanchiwai-ray commented 3 months ago

Can you please clarify "why" do we need this patch in the description? What issue is it trying to solve (example user story)? Thanks!

sudeephb commented 3 months ago

Closing in favor of #217. Setting the target as a dev branch because this feature needs an accompanying action to regenerate hw list before it's merged to main.