search

canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.
Apache License 2.0
7 stars 14 forks source link

[WIP]Refactor to support multiple exporters #218

Closed sudeephb closed 3 months ago

sudeephb commented 3 months ago

Some refactor so that adding a new exporter becomes simpler. After this is merged, a new exporter can be added by implementing:

  1. a new XxxExporter class that inherits from BaseExporter.
  2. Initialize the new exporter in charm init and append it to self.exporters.
chanchiwai-ray commented 3 months ago

Thanks for the hard works! I would suggest that refactoring at this scale should be merging into a staging branch (deb branch) and with multiple (smaller) chunks (e.g. renaming config option (which we should not because it's a non-compatible change), refactoring config handler, refactor service handler, refactor charms...) before goes to master branch.

sudeephb commented 3 months ago

Closing this in favor of #228 , which targets a dev branch, so the different stages can be reviewed and merged one by one.