Feat/smartctl exporter - Githubissues

canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.

Apache License 2.0

7 stars 14 forks source link

Feat/smartctl exporter #239

Closed jneo8 closed 1 month ago

jneo8 commented 2 months ago

Add support for smartctl exporter
Re-structure unit tests
- Remove the chaining unit-tests, use mock to build the boundary between functions.

chanchiwai-ray commented 2 months ago

It would be quicker to review if you could split refactoring (without adding smartctl) service.py as a separate PR, since with only that file change, it's too long that github decided to hide the diff