canonical / hardware-observer-operator

A charm to setup prometheus exporter for IPMI, RedFish and RAID devices from different vendors.
Apache License 2.0
7 stars 14 forks source link

Lack of support for domain based Redfish URL and TLS certificates #273

Open mastier opened 6 days ago

mastier commented 6 days ago

The customers would like to use domain names and globally valid certificate. However hardware-observer currently rely on bmc address fetch by ipmitool

It would be good to add support for redfish-hostname as optional argument

https://github.com/canonical/hardware-observer-operator/blob/e51d69ba2e93bbd42c5108230554df1a75d802c5/src/hardware.py#L67

https://github.com/canonical/hardware-observer-operator/blob/e51d69ba2e93bbd42c5108230554df1a75d802c5/src/hw_tools.py#L546

Optionally support for adding RootCA certificate that will verify the certificate against. Currently the cert verification is skipped. https://github.com/canonical/hardware-observer-operator/blob/e51d69ba2e93bbd42c5108230554df1a75d802c5/src/hw_tools.py#L548-L549