canonical / has-signed-canonical-cla

1 stars 16 forks source link

Allow external contributors without LP accounts #23

Open barrettj12 opened 1 year ago

barrettj12 commented 1 year ago

We have an new external contributor who just put up a PR. I asked them to sign the CLA and they did. However, this action is still failing on the PR.

We should not require external contributors to create a Launchpad account. We should be grateful for their help and not force them to jump through hoops.

I don't see why we can't just directly check their GH username / commit email against the CLA data. This seems a lot simpler and more reliable.

jhenstridge commented 1 year ago

Note that the first check is intended to cover private members of the group (it's using a token that should be able to check those memberships). If that's not working, then perhaps the token permissions have been revoked.