search

canonical / has-signed-canonical-cla

1 stars 16 forks source link

Implicit approval from licenses #35

Closed simondeziel closed 8 months ago

simondeziel commented 9 months ago

This implements the feature requested in #34

simondeziel commented 9 months ago

Thanks to @mihalicyn for pointing out a possible issue with \r\n end of line. This has been addressed to remove any trailing \r after splitting the lines of the commit message on \n.

tomponline commented 9 months ago

@lengau please can you take a look, thanks!

tomponline commented 8 months ago

Yes we do. Andrew Sinclair approved this approach.

lengau commented 8 months ago

Thanks for confirming!

lengau commented 8 months ago

@seb128 I'm not sure who other than you has write access on this repository :-)

seb128 commented 8 months ago

Thanks for the ping, the change is fine with me, we should probably give access to other people so let me know if you are interested in being a reviewer/maintainer for the project

tomponline commented 8 months ago

@seb128 yes please!