canonical / hotsos

Software analysis toolkit. Define checks in high-level language and leverage library to perform analysis of common Cloud applications.
Apache License 2.0
31 stars 37 forks source link

Add checks for Juju/Pebble CVE-2024-3250 #812

Closed sombrafam closed 4 months ago

dosaboy commented 4 months ago

Hi erlon, thank you for submitting this patch, we definitely need to get a check in for this cve asap.

You need to make a few adjustments here. Firstly, your patch is based on very old code (last updated Wed Apr 12 12:16:03 2023). You need to update your local repo and rebase your code to get the latest code from upstream (incl. pebble support). I have made a few comments inline and set a couple of action items to followup on.

sombrafam commented 4 months ago

I don't see your inline comments. I can see Nickola's and Pon's, but not yours.

dosaboy commented 4 months ago

sorry i forgot to submit them, they should be there now