coverage: ensure that "coverage clean" does its job - Githubissues

canonical / hotsos

Software analysis toolkit. Define checks in high-level language and leverage library to perform analysis of common Cloud applications.

Apache License 2.0

33 stars 38 forks source link

coverage: ensure that "coverage clean" does its job #872

Closed xmkg closed 6 months ago

xmkg commented 6 months ago

removed parameters from "coverage run" as they should be read from the .coveragerc file.

"coverage clean" now can see "coverage run" is being executed in parallel mode and can now clean the artifacts properly.

tox:testenv:coverage now runs "coverage clean" after the coverage report generation.

Supersedes #871

xmkg commented 6 months ago

We should also find a way to capture the interrupt signal and call the 'coverage clean'.

xmkg commented 6 months ago

We should also find a way to capture the interrupt signal and call the 'coverage clean'.

This is done.

xmkg commented 6 months ago

Now added the optional '-coverage' to py3 so we're now able to skip coverage related stuff on py3 env run.

xmkg commented 6 months ago

So I've made a few significant changes:

Coverage now writes its intermediate files to the tox's temp directory, so no tidying would be necessary (removed the bash interrupt handler thingy)
Moved .coveragerc contents to tox.ini
Renamed tox "coverage" env to "coveragereport"

I think the patch is now much cleaner.

dosaboy commented 6 months ago

nice cleanups in the final stage! lgtm!