canonical / hotsos

Software analysis toolkit. Define checks in high-level language and leverage library to perform analysis of common Cloud applications.
Apache License 2.0
32 stars 38 forks source link

Fix the way coverage is run #875

Closed brianphaley closed 4 months ago

brianphaley commented 4 months ago

Move all coverage commands into the 'coverage' section of tox.ini, else it will be run for every unit test run, for example, 'tox -e py3'.

brianphaley commented 4 months ago

This is what I had in mind. My only question now is do we run a coverage check in our jobs?

mustafakemalgilor commented 4 months ago

The existing method allows us to capture coverage data on the first run, so I think it's redundant to run the whole unit test suite again just for the coverage.

mustafakemalgilor commented 4 months ago

Hi @brianphaley

I addressed your concerns in #872, please have a look.

brianphaley commented 4 months ago

872 is good now, will close this one