search

canonical / hotsos

Software analysis toolkit. Define checks in high-level language and leverage library to perform analysis of common Cloud applications.
Apache License 2.0
32 stars 38 forks source link

scenarios/disk_failure: relax regex constraints #886

Closed mustafakemalgilor closed 4 months ago

mustafakemalgilor commented 4 months ago

the kernel timestamp format may differ between hosts, and we don't utilize the kernel timestamp in the scenario so removing it would allow us to cover more ground.

Fixes #883

mustafakemalgilor commented 4 months ago

Please also update hotsos/defs/scenarios/kernel/qla2xxx.yaml as well.

Done.

dosaboy commented 4 months ago

as you say, the timestamp is not needed by the scenario because it does not define any constraints. the global constraints (dictated by --all-logs/--max-logrotate-depth) are always applied but dont require this reqex pattern and use their own along with a timestamp matcher that does try to cover as many kernlog formats as possible (see https://github.com/canonical/hotsos/blob/8f5fde449bca4e0e4eca2dfa4d8dfbdf60c0b788/hotsos/core/ycheck/engine/properties/search.py#L81) so if we are missing one please try to update that.