canonical / httprequest-lego-provider

httprequest-lego-provider - charm repository.
Apache License 2.0
0 stars 3 forks source link

Add an all users option to list-domains action #68

Closed mthaddon closed 1 month ago

mthaddon commented 1 month ago

Applicable spec: N/A

Overview

Provide a way of listing domains for all users per https://github.com/canonical/httprequest-lego-provider/issues/67.

Rationale

https://github.com/canonical/httprequest-lego-provider/issues/67.

Module Changes

N/A

Checklist

amandahla commented 1 month ago

no blocker: There are messages warning about removing some CVE from trivyignore.Can it be removed?

mthaddon commented 1 month ago

no blocker: There are messages warning about removing some CVE from trivyignore.Can it be removed?

I tried removing them, but trivy flagged them all, so not sure why it's saying they can be removed. I've added them back in now.

github-actions[bot] commented 1 month ago

Test coverage for f8c24182ea78a79af74de40edbcce65522fcf4d7

Name                                                              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                                 0      0      0      0   100%
httprequest_lego_provider/apps.py                                     4      0      0      0   100%
httprequest_lego_provider/dns.py                                     68      0      8      0   100%
httprequest_lego_provider/forms.py                                   21      0      2      0   100%
httprequest_lego_provider/management/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/management/commands/__init__.py             0      0      0      0   100%
httprequest_lego_provider/management/commands/allow_domains.py       21      0      2      0   100%
httprequest_lego_provider/management/commands/create_user.py         14      0      0      0   100%
httprequest_lego_provider/management/commands/list_domains.py        22      0      8      0   100%
httprequest_lego_provider/management/commands/revoke_domains.py      21      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py                  8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/models.py                                   9      0      0      0   100%
httprequest_lego_provider/serializers.py                             24      0      0      0   100%
httprequest_lego_provider/urls.py                                     8      0      0      0   100%
httprequest_lego_provider/views.py                                   53      0      8      0   100%
-------------------------------------------------------------------------------------------------------------
TOTAL                                                               273      0     30      0   100%

Static code analysis report

Run started:2024-09-12 15:10:05.428382

Test results:
    No issues identified.

Code scanned:
    Total lines of code: 1547
    Total lines skipped (#nosec): 0
    Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
    Total issues (by severity):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
    Total issues (by confidence):
        Undefined: 0
        Low: 0
        Medium: 0
        High: 0
Files skipped (0):