refactor: refactor the charm

canonical / hydra-operator

Charmed Ory Hydra

https://charmhub.io/hydra

Apache License 2.0

2 stars 5 forks source link

Closed wood-push-melon closed 1 month ago

wood-push-melon commented 2 months ago

This pull request refactors the whole hydra-operator charm based on the specific idea.

Note:

did not use the CollectStatusEvent because there are several places where several pre-check conditions happen (set the status to some status if the condition fails).

shipperizer commented 1 month ago

@wood-push-melon we should drop the chore: merge main commits and do a proper rebase

wood-push-melon commented 1 month ago

Looks good to me.

Could we have a test for upgrading the charm? See example

Thanks. Will add the test for the charm upgrade.