search

canonical / hydra

OpenID Certified™ OpenID Connect and OAuth Provider written in Go - cloud native, security-first, open source API security for your infrastructure. SDKs for any language. Works with Hardware Security Modules. Compatible with MITREid.
https://www.ory.sh/hydra/?utm_source=github&utm_medium=banner&utm_campaign=hydra
Apache License 2.0
0 stars 1 forks source link

fix: add transaction to flow persistence #26

Closed nsklikas closed 1 month ago

nsklikas commented 1 month ago

Wrap the flow persistence and user_code invalidation in a transaction. This does not full solve the issue with having multiple flows persisted per user_code as need to fix https://github.com/canonical/hydra/issues/25 first.

nsklikas commented 1 month ago

Just one minor NONBLOCKING thing: I found the comments a bit unclear:

https://github.com/canonical/hydra/pull/26/files#diff-265e72885dd37a9d8c6f81e2c928b2bfad035cecd98051ef2f04ea88a56ed540R1229 https://github.com/canonical/hydra/pull/26/files#diff-265e72885dd37a9d8c6f81e2c928b2bfad035cecd98051ef2f04ea88a56ed540R1237

It would be nice to make them more clear.

These comments come from the upstream code, I will try to