Handle/fix live workers number in worker pool in case of a `recover` return is not nil

canonical / identity-platform-admin-ui

Admin UI for the Canonical identity broker and identity provider solution

Other

5 stars 4 forks source link

Handle/fix live workers number in worker pool in case of a `recover` return is not nil #262

Open BarcoMasile opened 3 months ago

BarcoMasile commented 3 months ago

Description

In internal/pool/pool.go, the private consume function needs to handle the correct number of live goroutines to make sure performance are not degraded in case some goroutine fails the setup phase.

defer func() {
    if r := recover(); r != nil {
        p.logger.Debug("Recovered in consume ", ID.String(), " ", r)
        p.wg.Done()
        return
    }
}()

syncronize-issues-to-jira[bot] commented 3 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-787.

This message was autogenerated