Make sure login errors from hydra are actually handled in the authentication/handlers.go

[BarcoMasile]

Description

We need to make sure that Admin Service correctly handles cases in which the Hydra login flow ended with an error. Hydra seems to redirect to Admin UI with error query parameters, we need to return a correct API response with the contextual errors.

In order to simulate this error we need to test this with:

• a failed login
• wrong client credentials (client-id + client-secret)
• wrong redirect URI Some of this will probably not even redirect to the Admin Service, in that case we won't be able to do much. But still, we need to return a 400 error in case something goes wrong and Hydra still redirects the useragent to the Admin UI.

[syncronize-issues-to-jira[bot]]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-919.

This message was autogenerated

[BarcoMasile]

In case the client-id or client-secret is misconfigured for admin-ui, we end up on the Login UI. We get redirected to Login UI with the following URL:

http://localhost:4455/ui/oidc_error?error=invalid_client&error_description=Client+authentication+failed+%28e.g.%2C+unknown+client%2C+no+client+authentication+included%2C+or+unsupported+authentication+method%29.+The+requested+OAuth+2.0+Client+does+not+exist.+Unable+to+locate+the+resource

[BarcoMasile]

Same goes for a misconfigured redirect URI. We get redirected to Login UI with the following URI:

http://localhost:4455/ui/oidc_error?error=invalid_request&error_description=The+request+is+missing+a+required+parameter%2C+includes+an+invalid+parameter+value%2C+includes+a+parameter+more+than+once%2C+or+is+otherwise+malformed.+The+%27redirect_uri%27+parameter+does+not+match+any+of+the+OAuth+2.0+Client%27s+pre-registered+redirect+urls.

[BarcoMasile]

Trying out a "failed login flow" with an external provider, in this case it's Github, we never get back to the Admin UI or Login UI for that matter. The login smiply fails and the user stays on Github login page.

Here are two examples, with a failed first factor authentication method...

...and with a failed second factory authentication method

[BarcoMasile]

Conclusion

Login UI already handles the first two kinds of errors decently, those fall in the misconfiguration scenario, for which we need to rely on the administrator deploying the Bundle or the Admin UI, making sure the login flow works correctly. There is no way to be alerted of a misconfiguration without running the app, unless we provide some sort of dynamic validation hitting hydra APIs, which is way overkill. Notice how between the first and second case the error message changes, but it's still pretty generic about what went wrong, and that's hydra not revealign too much about the situation, for security reasons.

For the external IdP scenario, I just tested Github, but although other IdPs tend to behave the same way, some may not. We should opportunistically check for other IdPs behavior as a best effort activity and make sure we handle errors in a graceful way. Although different providers may respond with different payloads / query parameters "schemas" so we'll see what we can do about having a generic approach to that.