search

canonical / is-charms-contributing-guide

The code contributing guide for the IS charms team
Apache License 2.0
2 stars 1 forks source link

add guidance on merging changes with failing status checks #53

Closed jdkandersson closed 1 year ago

jdkandersson commented 1 year ago

Added guidance on how to merge a PR with failing status checks

jdkandersson commented 1 year ago

Unfortunately, if test do not pass on PR submission they are unlikely to pass once merge, blocking the release of the changes.

Any ideas on how we could resolve this? Some ideas:

  1. The PR disables the failing status checks
  2. The charm is updated manually on charmhub
nrobinaubertin commented 1 year ago

Any ideas on how we could resolve this? Some ideas:

Could we have a "force release" command ? It could be a special keyword part of a commit message for example.

jdkandersson commented 1 year ago

Any ideas on how we could resolve this? Some ideas:

Could we have a "force release" command ? It could be a special keyword part of a commit message for example.

That would not be easy to implement. The easiest thing is probably to do a manual release after running the charm tests locally in these cases