canonical / is-charms-contributing-guide

The code contributing guide for the IS charms team
Apache License 2.0
2 stars 1 forks source link

add standard for using python-libjuju #62

Open jdkandersson opened 1 year ago

jdkandersson commented 1 year ago

Adds a standard for using the native functionality of python-libjuju instead of relying on command line interactions

gregory-schiano commented 1 year ago

Do we really want to put every single bit of advices in this doc ? This becomes heavy to read and will refrain anyone who wants to contribute :/

If we consider it more as an internal guideline, I'd suggest to keep it outside of github.

jdkandersson commented 1 year ago

Do we really want to put every single bit of advices in this doc ? This becomes heavy to read and will refrain anyone who wants to contribute :/

If we consider it more as an internal guideline, I'd suggest to keep it outside of github.

I have given this feedback on a few PRs now, I think that is an indication that we should write something like it so we don't have to constantly say the same thing on future PRs

gregory-schiano commented 1 year ago

Do we really want to put every single bit of advices in this doc ? This becomes heavy to read and will refrain anyone who wants to contribute :/ If we consider it more as an internal guideline, I'd suggest to keep it outside of github.

I have given this feedback on a few PRs now, I think that is an indication that we should write something like it so we don't have to constantly say the same thing on future PRs

Well I get your argument but: