search

canonical / is-charms-contributing-guide

The code contributing guide for the IS charms team
Apache License 2.0
2 stars 1 forks source link

Use step-down rule for of the order of function policy #77

Closed cbartz closed 5 months ago

cbartz commented 5 months ago

This is a follow-up to https://github.com/canonical/is-charms-contributing-guide/pull/68/files.

The guideline to list the dependent function after the function it depends on is removed by this PR, as this guideline has not been followed in many PRs, and there seems to be consensus that the team favours the step-down rule.

cbartz commented 5 months ago

@gregory-schiano @jdkandersson Please share your thoughts.

cbartz commented 5 months ago

Updated as there seems to be a consensus to use the step-down rule: https://github.com/canonical/is-charms-contributing-guide/pull/77#discussion_r1567158251