canonical / istio-ingress-k8s-operator

https://charmhub.io/istio-ingress-k8s
Apache License 2.0
0 stars 0 forks source link

update cert_handler charm lib to version that has stable hashes #18

Open ca-scribner opened 1 month ago

ca-scribner commented 1 month ago

Enhancement Proposal

15 includes a local fix to the cert_handler library to fix an issue with the hashing of cert input config

https://github.com/canonical/istio-ingress-k8s-operator/blob/ab1fda941b77985a1097d165df61fba18c0fbb7c/lib/charms/observability_libs/v1/cert_handler.py#L446-L456

This was required because previously the hashing was python session dependent, meaning sequential charm calls generated different hash values for the same inputs. The cert_handler recently received a similar fix, but it removed the refresh_events feature which we rely on here so we cannot immediately update to the new library. To fix this, we need to restore the refresh_events feature in cert_handler or find a new pattern to use here.