Bump to ops 2.10 and remove handling of missing relation data during relation-broken events - Githubissues

canonical / istio-operators

Charmed Istio

2 stars 17 forks source link

Bump to ops 2.10 and remove handling of missing relation data during relation-broken events #378

Open ca-scribner opened 9 months ago

ca-scribner commented 9 months ago

Context

To handle broken relations, istio-pilot has the following workaround:

https://github.com/canonical/istio-operators/blob/ea52577cb2595162cb61fcea7a9e332d5b6b3c34/charms/istio-pilot/src/charm.py#L537-L546

This was needed because a breaking application's data may or may not be present in the databag.

This behaviour has changed in ops 2.10.0 and the workaround should no longer be needed. We should test and remove it if possible

What needs to get done

test whether ops 2.10.0 fixes the relation-broken handling issue
remove the workaround

Definition of Done

charm is updated and pushed to main

syncronize-issues-to-jira[bot] commented 9 months ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5294.

This message was autogenerated