search

canonical / istio-operators

Charmed Istio
2 stars 17 forks source link

fix: shorten the summary as a workaround for canonical/charmcraft#1568 #389

Closed DnPlas closed 4 months ago

DnPlas commented 4 months ago

In recent versions of charmcraft, the summary line must not exceed 78 characters. This change has been introduced in v2.5, which is heavily used by CKF charms. Since pinning the charmcraft version to an earlier release won't scale correctly, it has been decided to move on with the workaround, which aligns more to what charmcraft will expect in the future.

See canonical/charmcraft#1568 for reference.

Testing instructions

We must ensure that changes in this metadata won't affect upgrades.

  1. Deploy istio-operators charms from charmhub v1.17 and relate them
  2. Refresh the istio-pilot to the version published by this PR
  3. Check for errors

NOTES:

  1. we must change this field in main and track/1.17
  2. the CI will fail because of kubeflow-volumes, #388 fixes the issue
NohaIhab commented 4 months ago

thank you @DnPlas this change makes sense. Can you point this pr and #388 to a dev branch because they are interdependent to unblock the CI? I'd like to see the CI passing before we merge to branch track/1.17

DnPlas commented 4 months ago

thank you @DnPlas this change makes sense. Can you point this pr and #388 to a dev branch because they are interdependent to unblock the CI? I'd like to see the CI passing before we merge to branch track/1.17

Thanks @NohaIhab, done, I have created the dev branch and pointed both PRs to it ^_^