canonical / istio-operators

Charmed Istio
2 stars 17 forks source link

feat: add support for istio 1.18.7 #415

Closed DnPlas closed 3 weeks ago

DnPlas commented 1 month ago

This commit adds support for istio operators 1.18.7.

Part of #413

Testing the upgrade path

See https://github.com/canonical/istio-operators/issues/413#issuecomment-2146960491

DnPlas commented 3 weeks ago

The changes look good. However, I tried upgrading both from 1.17 and latest/edge to this PR's charms

export CHANNEL=1.18/edge/pr-415
juju refresh istio-pilot --channel $CHANNEL && juju refresh istio-ingressgateway --channel $CHANNEL

and looks like upgrading istio-pilot fails with this error. Have you tried the upgrade path?

EDIT: I don't see any specific reference for deprecating precheck btw in Upgrade notes nor in Change notes

Yes, the issue was with the precheck command, it still needs the x for experimental features. I have added it back and will test once the publish job of this PR finishes.

EDIT: I have just tried upgrading from 1.17/stable to 1.18/edge/pr-415 and the charm goes to active w/o issues (: