search

canonical / istio-operators

Charmed Istio
2 stars 17 forks source link

fix: check routes before popping values #424

Closed DnPlas closed 4 months ago

DnPlas commented 4 months ago

This commit ensures the istio-pilot charm checks that the ingress routes dictionary it uses for reconciling VirtualServices from requirers is not empty and the relation data for the departing application is there before attempting to pop values during a RelationBroken event.

Fixes #423

Testing

  1. Follow the steps to reproduce in #423 to ensure the issue is happening
  2. Remove the charm and re-deploy it from this PR
  3. Try the steps in #423 again and make sure there is no error