search

canonical / istio-operators

Charmed Istio
2 stars 17 forks source link

Charms won't override existing state if changed #551

Open kimwnasptd opened 1 week ago

kimwnasptd commented 1 week ago

Bug Description

This is a follow-up from https://github.com/canonical/istio-operators/issues/549

We saw that, for some reason, the istio-validator-{model} ValidationWebhookConfiguration contain incorrectly formed data that redirected to a K8s svc that belonged to a different namespace.

Yet, the reconciliation loop of the Charm did not pick this up and overwrite the ValidationWebhookConfiguration to have the correct SVC

Expected behavior

To Reproduce

  1. Deploy the Istio charms
  2. Manually edit the ValidationWebhookConfiguration above (cluster scoped)
  3. Change the k8s svc used in the webhook to a random value

The Charm will never update the webhook with the correct value afterwards

Environment

Istio Charms from track/1.22

Relevant Log Output

<none>

Additional Context

We saw this happen because Istio was not removed properly.

Still it's not clear how we ended up having a istio-validator-kubeflow ValidationWebhookConfiguration object that pointed to istio-validator-kubeflow-dev (since it looks like values from different models were used)

syncronize-issues-to-jira[bot] commented 1 week ago

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6212.

This message was autogenerated