canonical / jhack

Chock-full of Juju hackery.
Apache License 2.0
48 stars 23 forks source link

scenario.scripts module import issue #114

Closed a-velasco closed 6 months ago

a-velasco commented 7 months ago

Summary

Import error ModuleNotFoundError: No module named 'scenario.scripts' when running any jhack command in the latest revision (bb8ab08ac13d1c288a17c9afef360b46edadbfc4).

Steps to Reproduce

Install jhack via pipx as follows:

sudo apt update
sudo apt install python3-pip python3-venv unzip -y
python3 -m pip install --user pipx
python3 -m pipx ensurepath
pipx install git+https://github.com/PietroPasotti/jhack.git

Run any jhack command. I've gotten the same output below with jhack utils tail, jhack utils, jhack --help, jhack ffwd ...

ubuntu@my-vm:~$ jhack utils tail
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/jhack", line 8, in <module>
    sys.exit(main())
  File "/home/ubuntu/.local/share/pipx/venvs/jhack/lib/python3.10/site-packages/jhack/main.py", line 58, in main
    from jhack.scenario.snapshot import snapshot
  File "/home/ubuntu/.local/share/pipx/venvs/jhack/lib/python3.10/site-packages/jhack/scenario/snapshot.py", line 28, in <module>
    from jhack.scenario.utils import JujuUnitName
  File "/home/ubuntu/.local/share/pipx/venvs/jhack/lib/python3.10/site-packages/jhack/scenario/utils.py", line 6, in <module>
    from scenario.scripts.errors import InvalidTargetUnitName
ModuleNotFoundError: No module named 'scenario.scripts'

Additional Context

The latest version of jhack I could get working on my system is "fixed unbork-juju script for juju 3+" https://github.com/PietroPasotti/jhack/commit/33adc418702e9b421596a1b042d897e86c3dc680 , installed via pipx install git+https://github.com/PietroPasotti/jhack.git@33adc418702e9b421596a1b042d897e86c3dc680

I suspect the breaking change is in https://github.com/PietroPasotti/jhack/commit/ea634fb12a0b46cd1c1fd6aaef4a00648a57ddbb

Operating System: Ubuntu 22.04.3 LTS pipx version: 1.3.3