canonical / jhack

Chock-full of Juju hackery.
Apache License 2.0
48 stars 23 forks source link

Option to disable blinking animation in `jhack nuke` #74

Closed carlcsaposs-canonical closed 1 year ago

carlcsaposs-canonical commented 1 year ago

Would it be possible to add an option to disable the blinking animation after running jhack nuke?

https://github.com/PietroPasotti/jhack/blob/5003726c3d3f5b478da3b7cfe69c59e75e662b04/jhack/utils/nuke.py#L381

For me, it's difficult to focus on the output of other commands in the terminal when it's blinking, so I often end up clearing my terminal, but then I lose output from the commands before

PietroPasotti commented 1 year ago

Awwww nooo that's like 99% of the purpose of that tool. Seriously though, I'll make it opt-in.

PietroPasotti commented 1 year ago

@carlcsaposs-canonical --> https://github.com/PietroPasotti/jhack/pull/75 if you have time to try it out and review, please :)