Replace subprocess with python-libjuju calls

canonical / juju-backup-all

Tool for backing up charms, local juju configs, and juju controllers.

Apache License 2.0

0 stars 5 forks source link

Replace subprocess with python-libjuju calls #11

Closed zxhdaze closed 7 months ago

zxhdaze commented 7 months ago

There are few places in the code, which rely on running subprocess and using juju.

It needs to be replaced with appropriate python-libjuju calls.

Imported from Launchpad using lp2gh.

date created: 2021-08-27T19:38:34Z
owner: smigiel-dariusz
assignee: None
the launchpad url

zxhdaze commented 7 months ago

(by zzehring) Currently, python-libjuju does not implement a couple of key functions we need for the tool: retrieving all controllers and creating controller backups.

Here are the GH Issues for implementing those features:

controllers: https://github.com/juju/python-libjuju/issues/529 controller backup: https://github.com/juju/python-libjuju/issues/529

Once those are implemented, we can remove the subprocess calls and add the lib calls.

zxhdaze commented 7 months ago

(by jfguedez) The upstream issues have been resolved. The current code in master uses the API for creating controller backups.