search

canonical / juju-backup-all

Tool for backing up charms, local juju configs, and juju controllers.
https://snapcraft.io/juju-backup-all
Apache License 2.0
0 stars 6 forks source link

No space left on device when doing the backup. #49

Closed jneo8 closed 4 hours ago

jneo8 commented 2 weeks ago

The backup directory is hardcoded (e.g., see here). If there is insufficient space, the backup will fail.

To resolve this, the directory should be parameterized. The next step is to add this parameter as a configuration option in the charm. We should provide separate arguments for each application.

The argument should apply to below applications:

chanchiwai-ray commented 3 days ago

@jneo8 can you provide more information why this is needed? and if this is only need to for postgres? If the disk is full, normally the charm can't help you anymore than providing error message saying that the disk is full

jneo8 commented 3 days ago

The case we get is the disk is full on /home/ubuntu/, but there are some space left on /tmp. It depends on how user mount the disk.

The possible improvement we can do is make it become a argument/configuration that user can choose where to store the backup files. Not hardcoded.

chanchiwai-ray commented 3 days ago

Yeah, that's an issue (and more or less should be fixed in the postgresql charm itself) but how about the other DBs? Are they a problem or not? We need to be more precise what are we going to fix. Since currently, they are also hardcoded