canonical / juju-dashboard

View the real-time status of your Juju or JAAS environment.
https://juju.is
GNU Lesser General Public License v3.0
23 stars 23 forks source link

WD-7282 - fix: Display dashboard with 0 controllers #1653

Closed vladimir-cucu closed 10 months ago

vladimir-cucu commented 10 months ago

Done

QA

Details

webteam-app commented 10 months ago

Demo starting at https://juju-dashboard-1653.demos.haus

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2622e20) 95.01% compared to head (d8031b3) 95.02%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1653 +/- ## ======================================= Coverage 95.01% 95.02% ======================================= Files 170 170 Lines 5120 5124 +4 Branches 1449 1454 +5 ======================================= + Hits 4865 4869 +4 Misses 233 233 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huwshimi commented 10 months ago

I was able to reproduce this and your fix works!

One thing I spotted was that the controllers page still lists "1 controller" even though there are none in the table.

Screenshot 2023-11-09 at 11 32 31 am
vladimir-cucu commented 10 months ago

I was able to reproduce this and your fix works!

One thing I spotted was that the controllers page still lists "1 controller" even though there are none in the table.

Screenshot 2023-11-09 at 11 32 31 am

Didn't spot this issue. I'll look into it. Thanks for the review!