WD-7718 - feat: Remove additional controllers feature

canonical / juju-dashboard

View the real-time status of your Juju or JAAS environment.

https://juju.is

GNU Lesser General Public License v3.0

23 stars 25 forks source link

WD-7718 - feat: Remove additional controllers feature #1676

Closed vladimir-cucu closed 9 months ago

vladimir-cucu commented 11 months ago

Done

Removed additional controllers feature.

QA

Verify that "Register a controller" button does not appear in controllers page.
Verify that /controllers?panel=register-controller route doesn't open the register controller panel.
Verify that artifacts related to additional controller feature have been removed.

Details

https://warthogs.atlassian.net/browse/WD-7718

Screenshots

Screenshot from 2023-12-06 05-52-29

webteam-app commented 11 months ago

Demo starting at https://juju-dashboard-1676.demos.haus

codecov[bot] commented 11 months ago

Files	Patch %	Lines
src/store/app/thunks.ts	66.66%	1 Missing :warning:

```diff @@ Coverage Diff @@ ## main #1676 +/- ## ========================================== - Coverage 94.95% 94.93% -0.03% ========================================== Files 178 177 -1 Lines 5238 5170 -68 Branches 1515 1500 -15 ========================================== - Hits 4974 4908 -66 + Misses 244 242 -2 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huwshimi commented 11 months ago

@vladimir-cucu one other thing we should remove in this PR is the docs for adding additional controllers: https://github.com/canonical/juju-dashboard/blob/main/HACKING.md#adding-additional-controllers.

vladimir-cucu commented 11 months ago

Looks good. Just need to confirm this feature can be removed before we merge it.

I converted the PR to draft, so that we do not merge it by mistake until the feature is confirmed.