Closed huwshimi closed 7 months ago
Demo starting at https://juju-dashboard-1704.demos.haus
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
e060dcb
) 95.44% compared to head (02e6af7
) 95.46%.
Files | Patch % | Lines |
---|---|---|
src/panels/RemoveSecretPanel/RemoveSecretPanel.tsx | 95.65% | 2 Missing :warning: |
src/panels/RemoveSecretPanel/Fields/Fields.tsx | 95.23% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good and works as expected locally (apart from the backend bug related to removing the last revision) 🚀
I'm going to land this even though this bug exists, as this is not the only place this bug affects us, and once we have a solution we can update all the places (if it doesn't get rectified on the backend).
Done
QA
juju update-secret <URI> token=34ae35facd4
(you can run the same command a few times and each time a new revision will get created).Details
https://warthogs.atlassian.net/browse/WD-8401