canonical / juju-dashboard

View the real-time status of your Juju or JAAS environment.
https://juju.is
GNU Lesser General Public License v3.0
23 stars 23 forks source link

WD-8401 - Remove secrets #1704

Closed huwshimi closed 7 months ago

huwshimi commented 7 months ago

Done

QA

Details

https://warthogs.atlassian.net/browse/WD-8401

webteam-app commented 7 months ago

Demo starting at https://juju-dashboard-1704.demos.haus

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e060dcb) 95.44% compared to head (02e6af7) 95.46%.

Files Patch % Lines
src/panels/RemoveSecretPanel/RemoveSecretPanel.tsx 95.65% 2 Missing :warning:
src/panels/RemoveSecretPanel/Fields/Fields.tsx 95.23% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1704 +/- ## ========================================== + Coverage 95.44% 95.46% +0.01% ========================================== Files 187 189 +2 Lines 5596 5686 +90 Branches 1616 1638 +22 ========================================== + Hits 5341 5428 +87 - Misses 235 238 +3 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

huwshimi commented 7 months ago

Looks good and works as expected locally (apart from the backend bug related to removing the last revision) 🚀

I'm going to land this even though this bug exists, as this is not the only place this bug affects us, and once we have a solution we can update all the places (if it doesn't get rectified on the backend).