Remove restrictions from BaseVerifier.run_action_on_units

[esunar]

I think it's becoming clear that limitation of BaseVerifier.run_action_on_units that prevents actions being run on units other than those that are part of the self.units is a burden with little added value. When I added this restriction I did not forsee that verifier would need to run actions on units other than those that are directly verified. This turned out to be false and additional helpers are being created in utils/unit.py to get around this issue.

I propose that we remove this restriction to make BaseVerifier.run_action_on_units more usable. We should:

• Remove restriction from BaseVerifier.run_action_on_units
• Remove helpers that provided unrestricted functionality from utils/unit.py
• Rewrite existing code that used helpers

---

Imported from Launchpad using lp2gh.

• date created: 2021-03-26T13:06:10Z

• owner: martin-kalcok

• assignee: rgildein

• the launchpad url

[esunar]

(by rgildein) I think we should removed the BaseVerifier.run_action_on_units & BaseVerifier.run_action_on_units and use only utils.unit.run_action_on_units & utils.unit.run_action_on_unit. Because the run_action_on_units function has nothing to do with BaseVerifier and is used an asyncio, so it makes sense to separate it. The BaseVerifier.run_action_on_all makes sense.