When a user wants to verify a single type of unit, juju-verify returns:
"""
$ juju verify reboot -m foundations-maas:openstack -u nova-compute-kvm/1 nova-compute-kvm/2
[WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-flash/8
[WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-hdd/8
[WARN] Machine 10 runs other principal unit that is not being checked: ceph-osd-hdd/7
[WARN] Machine 10 runs other principal unit that is not being checked: ceph-osd-flash/7
[OK] check_has_sub_machines check passed
[FAIL] Unit nova-compute-kvm/1 is running 94 VMs.
[FAIL] Unit nova-compute-kvm/2 is running 136 VMs.
[OK] Empty Availability Zone check passed.
"""
I think that's fine, as it gives clear information on the status of a machine, focusing on the units explicitly passed as arguments.
However, other uses cases should provide all the info from their respective checks:
Current output
"""
$ juju verify reboot -m foundations-maas:openstack -u nova-compute-kvm/1 nova-compute-kvm/2 ceph-osd-hdd/8
Units are not running same charm. Detected types: {'nova-compute', 'ceph-osd'}
$ juju verify reboot -m foundations-maas:openstack -M 10 11
Units are not running same charm. Detected types: {'ceph-osd', 'nova-compute'}
"""
Expected output: both commands above should behave as if 2 commands would have been run:
"""
$ juju verify reboot -m foundations-maas:openstack -u$ juju verify reboot -m foundations-maas:openstack -u nova-compute-kvm/1 nova-compute-kvm/2
$ juju verify reboot -m foundations-maas:openstack -u ceph-osd-hdd/8
"""
esunar
commented
1 year ago
When a user wants to verify a single type of unit, juju-verify returns: """ $ juju verify reboot -m foundations-maas:openstack -u nova-compute-kvm/1 nova-compute-kvm/2 [WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-flash/8 [WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-hdd/8 [WARN] Machine 10 runs other principal unit that is not being checked: ceph-osd-hdd/7 [WARN] Machine 10 runs other principal unit that is not being checked: ceph-osd-flash/7 [OK] check_has_sub_machines check passed [FAIL] Unit nova-compute-kvm/1 is running 94 VMs. [FAIL] Unit nova-compute-kvm/2 is running 136 VMs. [OK] Empty Availability Zone check passed. """
I think that's fine, as it gives clear information on the status of a machine, focusing on the units explicitly passed as arguments.
However, other uses cases should provide all the info from their respective checks:
$ juju verify reboot -m foundations-maas:openstack -M 10 11 Units are not running same charm. Detected types: {'ceph-osd', 'nova-compute'} """
Imported from Launchpad using lp2gh.
date created: 2021-11-19T16:39:15Z
owner: aluria
assignee: rgildein
the launchpad url