canonical / juju-verify

https://launchpad.net/juju-verify
GNU General Public License v3.0
2 stars 7 forks source link

Incorrect warning for "Maachine <name> runs other principal unit that is not being checked" #119

Closed esunar closed 1 year ago

esunar commented 1 year ago

In case that single machine runs 2 different units (e.g. nova-compute and ceph-osd) that are being checked simultaneously with juju-verify, user will get incorrect warning messages.

$ juju verify reboot -m foundations-maas:openstack -u nova-compute-kvm/1 nova-compute-kvm/2 ceph-osd-hdd/8
===[nova-compute-kvm/1, nova-compute-kvm/2]===
Checks:
[WARN] Machine 10 runs other principal unit that is not being checked: ceph-osd-flash/7
[WARN] Machine 10 runs other principal unit that is not being checked: ceph-osd-hdd/7
[WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-hdd/8
[WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-flash/8
[OK] check_has_sub_machines check passed
[FAIL] Unit nova-compute-kvm/1 is running 94 VMs.
[FAIL] Unit nova-compute-kvm/2 is running 146 VMs.
[OK] Empty Availability Zone check passed.

Result: Failed

===[ceph-osd-hdd/8]===
Checks:
[WARN] Machine 11 runs other principal unit that is not being checked: ceph-osd-flash/8
[WARN] Machine 11 runs other principal unit that is not being checked: nova-compute-kvm/2
[OK] check_has_sub_machines check passed
[OK] The requirements for ceph check were met.
[OK] ceph-mon/0: Ceph cluster is healthy
[OK] Minimum replica number check passed.
[OK] Availability zone check passed.

Result: OK (Checks passed with warnings)

In the example it can bee seen that each verifier reports units from other verifier as "not being checked".


Imported from Launchpad using lp2gh.

esunar commented 1 year ago

(by martin-kalcok) PR opened: https://github.com/canonical/juju-verify/pull/60