canonical / juju-verify

https://launchpad.net/juju-verify
GNU General Public License v3.0
2 stars 7 forks source link

multiple `--units` or ` --machines` arguments are ignored #124

Closed esunar closed 1 year ago

esunar commented 1 year ago

If provide multiple --units or --machines arguments that only the last one will be considered and no warning will be provided.

How it currently works:

(juju-verify) ➜  juju-verify git:(master) ✗ juju-verify reboot --units ceph-osd/0 --units ceph-osd/1 -l debug
Connecting to currently active model.
Inferred charm for unit ceph-osd/1: ceph-osd
Initiating verifier instance of class: CephOsd
Running check reboot on units: ceph-osd/1
Result: OK
Reason: ceph-mon/2: Ceph cluster is healthy

How it should works:

(juju-verify) ➜  juju-verify git:(master) ✗ juju-verify reboot --units ceph-osd/0 --units ceph-osd/1 -l debug
Connecting to currently active model.
Inferred charm for unit ceph-osd/0: ceph-osd
Inferred charm for unit ceph-osd/1: ceph-osd
Initiating verifier instance of class: CephOsd
Running check reboot on units: ceph-osd/0,ceph-osd/1
Result: OK
Reason: ceph-mon/0: Ceph cluster is healthy

Imported from Launchpad using lp2gh.

esunar commented 1 year ago

(by rgildein) I think that "extend" action 1 should be used to prevent this situation.


esunar commented 1 year ago

(by rgildein) MP: https://code.launchpad.net/~rgildein/juju-verify/+git/juju-verify/+merge/400337