Clicking terms in charm details page opens a new tab with JSON

[cmars]

Steps to reproduce:

1. Browse to a charm that requires agreement to terms. For example, https://jujucharms.com/u/cmars/mattermost
2. Click the terms link. For the above linked example, this would be "Isrg-Lets-Encrypt".
3. Instead of displaying terms, it opens a new tab containing JSON -- looks like the terms service API response containing the term that should be displayed.

[anthonydillon]

Does this mean the storefront needs a terms view? Or is link to the terms incorrect? Is there an existing terms view which we could link too?

[cmars]

@anthonydillon I believe the storefront needs a terms view, as it's currently linking directly to a terms API endpoint. I don't know what the UX design for terms in the details page is exactly, but I would imagine that at the very least, the SF should transform the 'content' field in each object in the JSON response into some HTML that displays the terms. Maybe a modal dialog or something?

The terms service knows nothing about HTML so the content should be sanitized accordingly, and lines wrapped to flow nicely. In many cases the content is the result of pdftoascii or a copy-and-paste.

[anthonydillon]

Thanks for the feedback. I don't think there are designs for this yet. I will pass this to the design team to work on it.

[spencerbygraves]

We have a design for terms, linked from plans in the deployment flow. Would this be the same terms?

https://github.com/CanonicalLtd/juju-design/issues/175

[spencerbygraves]

Or could a one page design like this be used?

[frankban]

The GUI uses a lightbox style terms visualizer, maybe we can do the same in the storefront?

[syncronize-issues-to-jira[bot]]

.github/.jira_sync_config.yaml file was not found