search

canonical / k8s-snap

Canonical Kubernetes is an opinionated and CNCF conformant Kubernetes operated by Snaps and Charms, which come together to bring simplified operations and an enhanced security posture on any infrastructure.
GNU General Public License v3.0
20 stars 6 forks source link

Update external-datastore.md #486

Open eaudetcobello opened 3 weeks ago

eaudetcobello commented 3 weeks ago

Just so we don't have to check if it goes under the cluster-config key or not.

eaudetcobello commented 3 weeks ago

Out of curiosity: Where does this change come from, did anyone complain or did this wrong?

You basically just rephrase what is implicitly there already hence I'm asking.

Before approval, please make the linter happy.

I don't think it's simply a rephrase, there is information added. The original "Insert the content below" does not make it obvious if the data should go under the cluster-config key or at the root level.

I was following the docs for external datastore and had to go check at which level the config goes.

bschimke95 commented 3 weeks ago

You are probably right, and I just am too much exposed to this codebase already.