[DPE-4582] Cruise Control - Githubissues

canonical / kafka-k8s-operator

Kafka K8s operator

Apache License 2.0

7 stars 11 forks source link

[DPE-4582] Cruise Control #114

Closed Batalex closed 3 months ago

Batalex commented 3 months ago

Feature branch to bring VM changes to this code base.

Done:

Charmed-kafka rock updated to include Cruise-control
Peer cluster relation
New sub-operator based code structure
Balancer integration test
Balancer auth
Unit tests
Merge Rebalance action #117
Prometheus port already used when running the same app #118

FIXME / to discuss?

Both workloads are running in the same container in single app deployment. Do we commit to this design decision?
The minimum storage size is still set at 10G, because Juju on k8s does not allow the storage to change during an update. Maybe there is a convoluted way to do that in our upgrade strategy, but for now that does not seem that big of a deal to keep 10G

Batalex commented 3 months ago

Did we choose to not go with the multiple containers? What was the reason for that? I can see advantages to both options, so just wondering on the motivation.

The change is quite trivial, so we can always go back to the alternative implementation. @zmraul and @deusebio made good points on how the current design (1) is closer to what is already done by other DP Charms and (2) avoids having mandatory empty containers (because declared in the YAML file, so unrelated to the roles config option)