canonical / kafka-k8s-operator

Kafka K8s operator
Apache License 2.0
7 stars 11 forks source link

[DPE-5097] - test: add mtls int-tests #133

Closed marcoppenheimer closed 2 months ago

marcoppenheimer commented 2 months ago

Changes Made

test: add mtls int-tests

deusebio commented 2 months ago

Oh, there is another thought I had:

It seems that we are only testing the trusted-certificates behaviour, and not the trusted-ca. Do we have a test for this? If not, I'd also like to test this scenario. If we can use a lot of code already written here, and this would be reasonably easy, I would make it part of this PR, otherwise I'm also fine to have a dedicated ticket. But I'd approach this next pulse

marcoppenheimer commented 2 months ago

@deusebio

Do we have a test for this?

No we don't, mostly to save headache of writing more fiddly mTLS tests for the 'easier' case of CA trusting (vs individual cert). Happy to for it to be a separate ticket, as both K8s + VM will need it 👍🏾

zmraul commented 2 months ago

It seems that we are only testing the trusted-certificates behaviour, and not the trusted-ca.

We don't, but the charm is executing the exact same code on both cases, minus a check on the relation name to get certificate or CA. It's good to have that test, but I don't think is critical IMO.