search

canonical / katib-rocks

ROCKs for Kubeflow Katib
Apache License 2.0
1 stars 9 forks source link

bump rocks from 0.16.0 to 0.17.0 #44

Closed TakoB222 closed 3 months ago

kimwnasptd commented 3 months ago

Thanks for the PR @TakoB222!

Can you also ensure that the folders have the tox.ini files and folder with tests, so that the CI can get triggered?

TakoB222 commented 3 months ago

Thanks for the PR @TakoB222!

Can you also ensure that the folders have the tox.ini files and folder with tests, so that the CI can get triggered?

Okay, will do!

kimwnasptd commented 3 months ago

@TakoB222 I realised I need to push a PR to enable the CI in this repo. Doing this ASAP and will ping you back to rebase to the latest main branch, to see if the CI gets triggered

kimwnasptd commented 3 months ago

@TakoB222 could you rebase on top of the latest master, which should now have the necessary CI from https://github.com/canonical/katib-rocks/pull/47?

TakoB222 commented 3 months ago

@TakoB222 could you rebase on top of the latest master, which should now have the necessary CI from #47?

Yes, sure!

kimwnasptd commented 3 months ago

Thanks for the PR @TakoB222! All the tests are now passing!